Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump devDependencies to their newest versions #1890

Merged
merged 19 commits into from
May 13, 2022
Merged

Bump devDependencies to their newest versions #1890

merged 19 commits into from
May 13, 2022

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented May 13, 2022

Note that eslint-plugin-eslint-plugin was not updated because v4.x doesn't seem to recognize ESLint rules in our codebase.

@FloEdelmann FloEdelmann added the dependencies Pull requests that update a dependency file label May 13, 2022
@FloEdelmann
Copy link
Member Author

FloEdelmann commented May 13, 2022

@ota-meshi The deploy on Netlify failed, but I don't know why. Can you try clearing the npm cache there and retry the build?

I noticed that I sometimes had to run npm install twice on my local machine as well, otherwise I got "MODULE_NOT_FOUND" issues.

@ota-meshi
Copy link
Member

I deleted the cache and re-run it and it was successful😀

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ota-meshi ota-meshi merged commit 07a7833 into master May 13, 2022
@ota-meshi ota-meshi deleted the dev-deps branch May 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants