Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue/no-invalid-attribute-name rule #1851

Merged
merged 22 commits into from May 17, 2022
Merged

Conversation

doug-wade
Copy link
Contributor

Adds the rule proposed in #1373

lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Show resolved Hide resolved
tests/lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
docs/rules/no-invalid-attribute-name.md Outdated Show resolved Hide resolved
@ota-meshi
Copy link
Member

I don't think the issue has reached consensus. Would you please write your thoughts in the issue?

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@doug-wade
Copy link
Contributor Author

Sorry @ota-meshi ; I thought the help wanted tag meant this was shovel-ready. I've updated the ticket with what I found in my investigation, and I'll reopen if we decide if the rule is something we want.

@doug-wade doug-wade closed this Apr 16, 2022
@doug-wade doug-wade reopened this Apr 21, 2022
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for changing this PR! I have some requests.

lib/rules/no-invalid-attribute-name.js Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Show resolved Hide resolved
tests/lib/rules/no-invalid-attribute-name.js Show resolved Hide resolved
tests/lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
@FloEdelmann FloEdelmann linked an issue Apr 21, 2022 that may be closed by this pull request
@ota-meshi ota-meshi changed the title Fix 1373 Add vue/no-invalid-attribute-name rule Apr 22, 2022
package.json Outdated Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
doug-wade and others added 2 commits May 8, 2022 12:32
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
tests/lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
tests/lib/rules/no-invalid-attribute-name.js Outdated Show resolved Hide resolved
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this PR because I want to include this rule in the v9 release. Thank you for much work on this PR.

@ota-meshi ota-meshi merged commit ab85fd6 into vuejs:master May 17, 2022
@doug-wade
Copy link
Contributor Author

@ota-meshi thank you so much for taking this one over the line for me. Life just got out of hand, and I really appreciate you getting this into v9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule Proposal: no-invalid-attribute-name
3 participants