Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positives due to conflicts with other rules in vue/no-unused-properties rule #1790

Merged
merged 1 commit into from Feb 4, 2022
Merged

Fix false positives due to conflicts with other rules in vue/no-unused-properties rule #1790

merged 1 commit into from Feb 4, 2022

Conversation

ota-meshi
Copy link
Member

fixes #1789

@ota-meshi ota-meshi added the bug label Feb 4, 2022
FloEdelmann
FloEdelmann approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I would have expected a more difficult fix. Also good that you added a regression test!

@ota-meshi
Copy link
Member Author

Yeah. It was difficult to debug, but it was easy to fix 😄

@ota-meshi ota-meshi merged commit bd1fcb5 into master Feb 4, 2022
@ota-meshi ota-meshi deleted the issue1789 branch February 4, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unused-properties: Misses v-bind inside "style" section (with repro)
2 participants
@ota-meshi @FloEdelmann