Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vue2 functional component to vue/no-unused-properties and vue/no-undef-properties rules #1761

Merged
merged 1 commit into from Jan 19, 2022

Conversation

ota-meshi
Copy link
Member

close #1312
close #1669

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! I have one little remark though.

lib/utils/property-references.js Show resolved Hide resolved
@ota-meshi ota-meshi merged commit 5ed7397 into master Jan 19, 2022
@ota-meshi ota-meshi deleted the functional-component-vue2 branch January 19, 2022 10:00
@adamchipperfield
Copy link

I'm running 8.7.1 and am still having this issue, but it does look like it was released. Any ideas?

@adamchipperfield
Copy link

adamchipperfield commented Apr 22, 2022

I'm running 8.7.1 and am still having this issue, but it does look like it was released. Any ideas?

On deeper investigation it doesn't detect the props not used in the template of a SFC. For example, the prop handle exists and is used in <script> via props.handle. But the linter still calls out handle as not being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants