Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on <textarea> without end tag in vue/html-indent rule #1755

Merged
merged 2 commits into from Jan 8, 2022
Merged

Fix crash on <textarea> without end tag in vue/html-indent rule #1755

merged 2 commits into from Jan 8, 2022

Conversation

ota-meshi
Copy link
Member

fixes #1752

@ota-meshi ota-meshi added the bug label Jan 5, 2022
FloEdelmann
FloEdelmann reviewed Jan 5, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from a minor readability improvement.

I guess that now vue/no-parsing-error complains about this missing end tag?

lib/utils/indent-common.js Outdated Show resolved Hide resolved
@ota-meshi
Copy link
Member Author

I guess that now vue/no-parsing-error complains about this missing end tag?

vue/no-parsing-error rule does not report an error. Users can find the error using the vue/html-end-tags rule.

https://ota-meshi.github.io/eslint-plugin-vue-demo/#eJxtjMEKwyAQBX8l7DlLoMcQ+iW9iD5aixpxVwmE/HttDyGHHmcGZie7OtBMiyLmYBT3RxqGTpuaAtNpmS6JRio1QGjeqVVMdo0RSdn5Aqu+9dVt/JW3bFwFws0UOa3Y4rOyQGv+k18aAyM5VvP82uP4ANkCOHw=

FloEdelmann
FloEdelmann approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ota-meshi ota-meshi merged commit a475176 into master Jan 8, 2022
@ota-meshi ota-meshi deleted the issue1752 branch January 8, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/html-indent errors while using <textarea>
2 participants
@ota-meshi @FloEdelmann