Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new rule vue/prefer-separate-static-class #1729

Merged
merged 8 commits into from Dec 3, 2021
Merged

Add new rule vue/prefer-separate-static-class #1729

merged 8 commits into from Dec 3, 2021

Conversation

FloEdelmann
Copy link
Member

Fixes #1726.

@FloEdelmann FloEdelmann marked this pull request as draft November 29, 2021 08:28
@FloEdelmann FloEdelmann marked this pull request as ready for review December 1, 2021 18:02
ota-meshi
ota-meshi requested changes Dec 3, 2021
View reviewed changes
lib/rules/prefer-separate-static-class.js Outdated Show resolved Hide resolved
lib/rules/prefer-separate-static-class.js Outdated Show resolved Hide resolved
docs/rules/prefer-separate-static-class.md Outdated Show resolved Hide resolved
docs/rules/prefer-separate-static-class.md Outdated Show resolved Hide resolved
ota-meshi
ota-meshi approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ota-meshi ota-meshi merged commit 8a0b2c8 into vuejs:master Dec 3, 2021
@FloEdelmann FloEdelmann deleted the prefer-separate-static-class branch December 3, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi ota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: vue/prefer-separate-static-class
2 participants
@FloEdelmann @ota-meshi