Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare suggestable rules for ESLint v8 (and update eslint-plugin-eslint-plugin to v3) #1607

Merged
merged 1 commit into from Aug 13, 2021

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Aug 13, 2021

@bmish bmish changed the title Update eslint-plugin-eslint-plugin to v3 and prepare suggestable rules for ESLint v8 Prepare suggestable rules for ESLint v8 (and update eslint-plugin-eslint-plugin to v3) Aug 13, 2021
…n-eslint-plugin to v3)

* The upcoming [ESLint v8](https://eslint.org/blog/2021/06/whats-coming-in-eslint-8.0.0#rules-with-suggestions-now-require-the-metahassuggestions-property) release will require rules that provide suggestions to enable `meta.hasSuggestions` so I have autofixed that using the [eslint-plugin/require-meta-has-suggestions](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/blob/master/docs/rules/require-meta-has-suggestions.md) rule
* A lot of the rules/functionality in `eslint-internal-rules` have been replaced by public rules in [eslint-plugin-eslint-plugin](https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin)
@bmish bmish force-pushed the eslint-plugin-eslint-plugin-v3 branch from 1271d99 to bfb35f4 Compare August 13, 2021 17:14
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@ota-meshi ota-meshi merged commit 1fc3485 into vuejs:master Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants