Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added options for events that ignore custom-event-name-casing #1321

Merged
merged 7 commits into from Oct 18, 2020

Conversation

devTeaa
Copy link
Contributor

@devTeaa devTeaa commented Oct 8, 2020

Hi, currently there are some components from library that still uses pascalCase when passing the function
<customComponent @maskClick="handleMaskClick"/> this changes added options so it can ignore some event naming just like in component-name-in-template-casing.

What do you think?

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

Perhaps this PR solves #1260 (comment).
Could you add test cases to check ignores input:update, search:update and click:row?

Could you also add description of the new option to the documentation?
https://github.com/vuejs/eslint-plugin-vue/blob/master/docs/rules/custom-event-name-casing.md

@devTeaa
Copy link
Contributor Author

devTeaa commented Oct 8, 2020

Updated the docs

image

@devTeaa devTeaa requested a review from ota-meshi October 8, 2020 11:59
tests/lib/rules/custom-event-name-casing.js Outdated Show resolved Hide resolved
docs/rules/custom-event-name-casing.md Outdated Show resolved Hide resolved
docs/rules/custom-event-name-casing.md Show resolved Hide resolved
tests/lib/rules/custom-event-name-casing.js Outdated Show resolved Hide resolved
devTeaa and others added 2 commits October 9, 2020 09:50
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@devTeaa
Copy link
Contributor Author

devTeaa commented Oct 9, 2020

Added an example for ignores options

image

package.json Outdated Show resolved Hide resolved
Copy link
Contributor Author

@devTeaa devTeaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!
I will include this change in the next release.

@devTeaa
Copy link
Contributor Author

devTeaa commented Oct 9, 2020

Thanks for helping the review!

@ota-meshi ota-meshi merged commit 9932d13 into vuejs:master Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants