Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TransitionGroup is missing the style scope attribute on SSR #7554

Closed
posva opened this issue Jan 19, 2023 · 0 comments · Fixed by #7557
Closed

TransitionGroup is missing the style scope attribute on SSR #7554

posva opened this issue Jan 19, 2023 · 0 comments · Fixed by #7557
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working regression scope: ssr scope: transition

Comments

@posva
Copy link
Member

posva commented Jan 19, 2023

Vue version

edge

Link to minimal reproduction

https://sfc.vuejs.org/#__SSR__eNp9kMFugzAMhl/F8rkQaUfGKu2+R8iFglvSQhLZgalCvPscuk1VK5VTbP//92Mv+BljOU+EFdaJxjg0ifbW21Qnbry45IIvThymCKk5fVjs3GwR2qER0Yqps7jp1SGx8TAXx8A6ceA8vKm0utA116pbFnCwriB9mIYODgTqr0323TLNY6i2AWrNfEoE/bbE/Ze7EKTeCQRP/zSdGvXpS6l3i/la0nUgkDZE6jZhqUxYbsg2DIGr/F/vubFm+2bY4w7dGAOnYmxieZbg9WabS5fbBmKx+uNY1KPm2mKfUpTKGDm2+dJnKQOfjL5KnnxyI5UkY3Hg8C3ECra4u2MYbc7EBZPviIlfMR+kT9zfjVZcfwCSia2C

Steps to reproduce

  • open the link

What is expected?

  • all text should be red

What is actually happening?

  • text within the transition-group isn't

System Info

na

Any additional comments?

This appears to be a regression of

The div is missing is style scope id
@posva posva added 🐞 bug Something isn't working scope: transition scope: ssr ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. labels Jan 19, 2023
@baiwusanyu-c baiwusanyu-c mentioned this issue Jan 20, 2023
Merged
@sodatea sodatea added has PR A pull request has already been submitted to solve the issue regression labels Mar 24, 2023
yyx990803 pushed a commit that referenced this issue Oct 20, 2023
@baiwusanyu-c
fix(compiler-ssr): fix missing scopeId on server-rendered TransitionG…
61c1357 
…roup (#7557)

close #7554
yyx990803 pushed a commit that referenced this issue Oct 21, 2023
@baiwusanyu-c @yyx990803
fix(compiler-ssr): fix missing scopeId on server-rendered TransitionG…
9ad10a6 
…roup (#7557)

close #7554
lumozx pushed a commit to lumozx/core that referenced this issue Oct 21, 2023
@baiwusanyu-c @lumozx
fix(compiler-ssr): fix missing scopeId on server-rendered TransitionG…
a31232b 
…roup (vuejs#7557)

close vuejs#7554
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. has PR A pull request has already been submitted to solve the issue 🐞 bug Something isn't working regression scope: ssr scope: transition
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(compiler-ssr): TransitionGroup owns style-scoped properties on SSR baiwusanyu-c/bwsy-vue-core
2 participants
@posva @sodatea