Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): pruneCacheEntry rectify the judgment logic (fix #7355) #7510

Merged
merged 2 commits into from Feb 1, 2023

Conversation

GRPdream
Copy link
Contributor

@GRPdream GRPdream commented Jan 12, 2023

keep-alive component status abnormal when cache items more than its max, after debugging, I found that it judge 2 VNode is same logic is wrong(as cached.type !== current.type).
Issues link: #7355
Playground Before:
https://codesandbox.io/s/emit-issue-kezqfe

…ejs#7355)

keep-alive component status abnormal when cache items more than its max, after debugging, I found that its judge 2 VNode is same logic is wrong(as cached.type !== current.type).
@netlify
Copy link

netlify bot commented Jan 12, 2023

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 64af9ff
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/63bf7f1c354b5200085dd5c6

@GRPdream GRPdream marked this pull request as draft January 12, 2023 03:36
@GRPdream GRPdream marked this pull request as ready for review January 12, 2023 03:48
@GRPdream GRPdream marked this pull request as draft January 12, 2023 03:48
@GRPdream GRPdream marked this pull request as ready for review January 12, 2023 06:13
@GRPdream GRPdream marked this pull request as draft January 12, 2023 06:15
@GRPdream GRPdream closed this Jan 12, 2023
@GRPdream GRPdream reopened this Jan 12, 2023
@GRPdream GRPdream marked this pull request as ready for review January 12, 2023 06:27
@GRPdream
Copy link
Contributor Author

@LinusBorg Hoping to help approval workflow and review code #7355

@funkyvisions
Copy link

I've applied this patch locally and it seems to address my initial issue.

@yyx990803 yyx990803 merged commit 1fde49c into vuejs:main Feb 1, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
IAmSSH pushed a commit to IAmSSH/core that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants