Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcemap-codec deprecated warning #7329

Closed
kingyue737 opened this issue Dec 12, 2022 · 12 comments · Fixed by #8196
Closed

sourcemap-codec deprecated warning #7329

kingyue737 opened this issue Dec 12, 2022 · 12 comments · Fixed by #8196
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.

Comments

@kingyue737
Copy link

kingyue737 commented Dec 12, 2022

Vue version

3.2.45

Link to minimal reproduction

Ignore

Steps to reproduce

Install a package depending on @vue/reactivity-transform or @vue/compiler-sfc.
These two packages use magic-string of an old version which depends on deprecated sourcemap-codec

What is expected?

No warning

What is actually happening?

PNPM gives the following warning:

 WARN  deprecated sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead

System Info

No response

Any additional comments?

According to sxzz, require rollup/plugins#1373 to be merged

@sxzz
Copy link
Member

sxzz commented Dec 13, 2022

We also have to wait @rollup/plugin-commonjs, rollup-plugin-node-polyfills, @rollup/plugin-inject, @rollup/plugin-replace to upgrade their magic-string deps.

relate PR rollup/plugins#1373

@sxzz sxzz added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Dec 13, 2022
@ice1000
Copy link

ice1000 commented Dec 17, 2022

rollup/plugins#1373 is merged :)

@sxzz
Copy link
Member

sxzz commented Dec 17, 2022

remorses/esbuild-plugins#19
This PR is also blocking...

@burkenyo
Copy link

I was about to open an issue but I see you all are already on top of it. Keep up the great work, team Vue!

@ice1000
Copy link

ice1000 commented Jan 26, 2023

remorses/esbuild-plugins#19 is merged!

@MichaelDeBoey
Copy link

@ice1000 Unfortunately it's reversed 😢
remorses/esbuild-plugins#28 (comment)

@MBoretto
Copy link

Is there any quick fix for that?

@MichaelDeBoey
Copy link

@MBoretto The fix would be helping me re-implement it in remorses/esbuild-plugins#29 without that bug 🤷‍♂️

@p-m-p
Copy link

p-m-p commented Feb 1, 2023

I added remorses/esbuild-plugins#32 on top of @MichaelDeBoey PR to fix those internal modules. It's quite hard to test in that repo but I think it solve the issue.

@1581433801
Copy link

Has the problem been resolved?

@sxzz
Copy link
Member

sxzz commented Apr 27, 2023

Fixed in v3.3.0-alpha.6.

@esbuild-plugins/node-modules-polyfill is a dev dep and won't affect in userland.

@ice1000
Copy link

ice1000 commented Apr 27, 2023

Nice!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants