Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exchange the order of setScopeId and props initiate #6948

Merged
merged 3 commits into from Nov 14, 2022
Merged

Conversation

zollero
Copy link
Contributor

@zollero zollero commented Oct 25, 2022

Exchange the order of setScopeId and props initiate, and update the test case. #6923

@netlify
Copy link

netlify bot commented Oct 25, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 1d25db4
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/635796687007a2000852cf03

@edison1105
Copy link
Member

edison1105 commented Nov 3, 2022

in vue3

<section id="hero" data-v-76d4cf95>

in vue2

<section data-v-76d4cf95 id="hero">

This change will consistent with vue2.
LGTM.

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label Nov 3, 2022
@yyx990803 yyx990803 merged commit da2ced1 into vuejs:main Nov 14, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants