Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-core): avoid duplicate keys with v-if #6689

Merged
merged 3 commits into from Nov 8, 2022

Conversation

zhangzhonghe
Copy link
Member

fix #6631

@jd-solanki
Copy link

Hi,

Is there any timeline for when this will be merged/released?

Copy link
Member

@antfu antfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the nitpicking on naming, the implementation LGTM

packages/compiler-core/src/utils.ts Outdated Show resolved Hide resolved
@antfu antfu changed the title fix(compiler-core): avoid duplicate keys fix(compiler-core): avoid duplicate keys with v-if Oct 12, 2022
@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 93e3b81
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/634674514fb345000974569e

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for vuejs-coverage failed.

Name Link
🔨 Latest commit 93e3b81
🔍 Latest deploy log https://app.netlify.com/sites/vuejs-coverage/deploys/6346745187c1060008d95967

@yyx990803 yyx990803 merged commit 640cfce into vuejs:main Nov 8, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
zhangzhonghe added a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate key is generate when compiling vue SFC to JS
5 participants