Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hgroup support #6313

Closed
ennioVisco opened this issue Jul 20, 2022 · 5 comments · Fixed by #6321
Closed

Hgroup support #6313

ennioVisco opened this issue Jul 20, 2022 · 5 comments · Fixed by #6321
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. good first issue Good for newcomers has PR A pull request has already been submitted to solve the issue ✨ feature request New feature or request

Comments

@ennioVisco
Copy link

What problem does this feature solve?

It seems that the html working group has recently revamped the formerly deprecated hgroup tag, so it should be added in the list of the supported tags. See mdn/content#18530.

What does the proposed API look like?
@ennioVisco ennioVisco added the ✨ feature request New feature or request label Jul 20, 2022
@LinusBorg LinusBorg added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. good first issue Good for newcomers labels Jul 20, 2022
@puskuruk
Copy link
Contributor

If it's OK, I want to work on this issue, and it'll be my first contribution to Vue.js 🎉

@puskuruk puskuruk mentioned this issue Jul 20, 2022
Merged
@Justineo Justineo added the has PR A pull request has already been submitted to solve the issue label Jul 20, 2022
@LinusBorg LinusBorg linked a pull request Jul 20, 2022 that will close this issue
chore: add hgroup to supported HTML_TAGS (fix: #6313) #6321
Merged
@puskuruk
Copy link
Contributor

Ping 🙈

@ennioVisco
Copy link
Author

Ping 🙈

?

@puskuruk
Copy link
Contributor

I don't know how the Vue.js team works and when I didn't get any feedback yet, I wanted to remind you again.

@ennioVisco
Copy link
Author

I don't know how the Vue.js team works and when I didn't get any feedback yet, I wanted to remind you again.

it works, like in any open source project, that you should tag maintainers in the pull request, not ping regular users in the original issue 😝

@mwargan mwargan mentioned this issue Aug 3, 2022
Closed
@edison1105 edison1105 mentioned this issue Sep 15, 2022
Closed
yyx990803 pushed a commit that referenced this issue Nov 14, 2022
@puskuruk
fix(compiler): add hgroup to supported HTML_TAGS (#6321)
7443174 
close #6313
chrislone pushed a commit to chrislone/core that referenced this issue Feb 4, 2023
@puskuruk
fix(compiler): add hgroup to supported HTML_TAGS (vuejs#6321)
8d39bba 
close vuejs#6313
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this issue Apr 12, 2023
@puskuruk @zhangzhonghe
fix(compiler): add hgroup to supported HTML_TAGS (vuejs#6321)
a404681 
close vuejs#6313
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. good first issue Good for newcomers has PR A pull request has already been submitted to solve the issue ✨ feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add hgroup to supported HTML_TAGS (fix: #6313) puskuruk/vuejs-core
4 participants
@ennioVisco @LinusBorg @Justineo @puskuruk