Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App created with 'createSSRApp()' on the client side is not unmounted when call 'app.unmount()' method. #5990

Closed
hiuny opened this issue May 24, 2022 · 6 comments · Fixed by #5992

Comments

@hiuny
Copy link

hiuny commented May 24, 2022

Vue version

3.2.33

Link to minimal reproduction

https://stackblitz.com/edit/vitejs-vite-jycpna?file=src/main.js

Steps to reproduce

  1. open reproduction link
  2. wait 3 seconds

What is expected?

After 3 seconds of opening the reproduction link, the vue app should unmount. The counter should not work.

What is actually happening?

Even though app.unmount() is called, the counter is still running. Even if the app is created with createSSRApp() on the client side, it must be unmounted when the app.unmount() method is called. Just like createApp().

System Info

No response

Any additional comments?

@LinusBorg
Copy link
Member

LinusBorg commented May 24, 2022

why would you use createSSRApp() on the client side when it's for the server-side?

Edit: I'm a dumb-dumb.

@hiuny
Copy link
Author

hiuny commented May 24, 2022

When using ssr, must use 'createSSRApp()' on the client side. This is also stated in the vue.js ssr guide document. https://vuejs.org/guide/scaling-up/ssr.html#client-hydration

@LinusBorg
Copy link
Member

Sent a PR

@hiuny
Copy link
Author

hiuny commented May 25, 2022

@LinusBorg Thank you so much.

@hiuny
Copy link
Author

hiuny commented May 25, 2022

@LinusBorg
Thank you very much for the bug fix. I checked by installing the bug-fixed version (3.2.36). However, the container._vnode = vnode code seems to be missing. Please check if the build is not successful.

Oh, I misunderstood. Sorry. When is the release?

@yyx990803
Copy link
Member

Please do not ask when it will be released. It will be released when appropriate.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants