allow opting out from events timestamp check (fix #2513, #3933) #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for vue-sfc-playground failed.
|
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Any chance we can actually get this merged? |
|
I would also highly appreciate a merge! |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new app config:
skipEventsTimestampCheck.This boolean config option allows opting out from the events timestamp check.
The timestamp check seems to have been introduced in 360a10f to fix rare edge cases, but it also introduces new bugs that prevent some events from firing when mounting components in iframes (see #2513) or new browser windows (see #3933).
The introduced bug can render an application unusable, as many events won't fire; only those who pass the timestamp check do.
This PR does not introduce any breaking changes and sets the new config option to false by default for backward compatibility.
Closes #2513 #3933