Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): Optimize the value of emitIdentifier. #5394

Merged
merged 2 commits into from Oct 26, 2022
Merged

fix(compiler-sfc): Optimize the value of emitIdentifier. #5394

merged 2 commits into from Oct 26, 2022

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Feb 10, 2022

fix #5393

@netlify
Copy link

netlify bot commented Feb 10, 2022 •
edited

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 547d25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/6204bd5d2f13ce0007bb6024

😎 Browse the preview: https://deploy-preview-5394--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Feb 10, 2022 •
edited

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 547d25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/6204bd5d5f3f9f000802265d

😎 Browse the preview: https://deploy-preview-5394--vuejs-coverage.netlify.app

@netlify
Copy link

netlify bot commented Feb 10, 2022 •
edited

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 547d25f

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/6204bd5d3f8ab80008074d15

😎 Browse the preview: https://deploy-preview-5394--vue-sfc-playground.netlify.app/

@antfu antfu added the ready to merge The PR is ready to be merged. label Oct 5, 2022
@yyx990803 yyx990803 merged commit eab7604 into vuejs:main Oct 26, 2022
chrislone pushed a commit to chrislone/core that referenced this pull request Feb 4, 2023
@ygj6
fix(compiler-sfc): allow type annotation for defineEmits variable (vu…
2316151 
…ejs#5394)

fix vuejs#5393
zhangzhonghe pushed a commit to zhangzhonghe/core that referenced this pull request Apr 12, 2023
@ygj6 @zhangzhonghe
fix(compiler-sfc): allow type annotation for defineEmits variable (vu…
6b1a91e 
…ejs#5394)

fix vuejs#5393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

@sxzz sxzz sxzz approved these changes

@antfu antfu antfu approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Valid typescript when using defineEmits() results in bad code transformation during compile
5 participants
@ygj6 @edison1105 @sxzz @antfu @yyx990803