HMR doesn't update component which uses directives #4077
Merged
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
approved these changes
Jul 15, 2021
|
@edison1105 can you approve to run tests? |
|
@edison1105 is it my failure, or with my changes all ok? |
Sorry, I have no permission to re-run CI.the failure seems not to relate to this PR. If you rebase your code from the master branch and push again. the CI will re-run. |
|
This has been hitting me a lot lately. Would be great if this can be merged soon. Thank you! |
❌ Deploy Preview for vue-next-template-explorer failed.
|
❌ Deploy Preview for vue-sfc-playground failed.
|
❌ Deploy Preview for vuejs-coverage failed.
|
This was referenced Nov 10, 2022
7 tasks
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is reopen for #1942 and #1945 because:
After change prop value on component, HMR won't update prop if component has directive.
This reproduced if component in second or more level in SFC.