Skip to content

chore: upgrade vue to 2.6.14 #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Jun 15, 2021

This PR and vuejs/vue#12132 work together to solve the problem of compilation warnings after the vue in composition-api is upgraded to the latest version.

Before vuejs/vue#12132 is merged, we will see that ci fails to run.

@ygj6 ygj6 requested a review from posva June 16, 2021 08:03
@ygj6 ygj6 marked this pull request as draft June 16, 2021 08:03
@ygj6 ygj6 marked this pull request as ready for review June 22, 2021 07:04
@ygj6 ygj6 changed the title chore: upgrade vue to 2.6.14 and delete the same types for VueConstructor. chore: upgrade vue to 2.6.14 Jun 22, 2021
@ygj6
Copy link
Member Author

ygj6 commented Jun 22, 2021

This PR and vuejs/vue#12132 work together to solve the problem of compilation warnings after the vue in composition-api is upgraded to the latest version.

Before vuejs/vue#12132 is merged, we will see that ci fails to run.

@antfu @posva Now it is solved by shielding the warning, no longer dependent on vuejs/vue#12132

@posva
Copy link
Member

posva commented Jun 23, 2021

After further investigation, your initial solution (vuejs/vue#12132) is probably a better idea. Merging that one would allow to not change anything here, right?

@ygj6
Copy link
Member Author

ygj6 commented Jun 24, 2021

After further investigation, your initial solution (vuejs/vue#12132) is probably a better idea. Merging that one would allow to not change anything here, right?

Here I have deleted invalid module extension of VueConstructor:
https://github.com/vuejs/composition-api/pull/731/files#:~:text=interface%20VueConstructor%20%7B,defineReactive(

Because they are already defined in vue/types/vue, so the extension here will not take effect.

I noticed that you added the null type here:
dd2cd6b#:~:text=export%20function%20warn(msg%3A%20string%2C%20vm%3F%3A%20Vue%20%7C%20null)%20%7B

but there is no null type in Vue: https://github.com/vuejs/vue/blob/656a3cbda089c26938802707223254990631b91f/types/vue.d.ts#L125

which will cause a warning, so I temporarily deleted the null here: https://github.com/vuejs/composition-api/pull/731/files#:~:text=export%20function%20warn(msg%3A%20string%2C%20vm%3F%3A%20Vue%20%7C%20null)

If don't want to delete null, we also could add null type in Vue. @posva Which solution do you think is better?

@antfu antfu closed this in 4f738f7 Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants