Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Date infer string in props #627

Merged
merged 1 commit into from
Jan 14, 2021
Merged

fix: Date infer string in props #627

merged 1 commit into from
Jan 14, 2021

Conversation

Zcating
Copy link
Contributor

@Zcating Zcating commented Jan 8, 2021

No description provided.

pikax
pikax approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add it on vue-next?

https://github.com/vuejs/vue-next/blob/master/packages/runtime-core/src/componentProps.ts#L92-L100

https://github.com/vuejs/vue-next/blob/master/test-dts/defineComponent.test-d.tsx#L36

Thank you

@Zcating
Copy link
Contributor Author

Zcating commented Jan 8, 2021 •
edited

See this issue: Setting "Date" type as props will infer to string in the setup function, I copied from it.

@antfu antfu merged commit b2acb2d into vuejs:master Jan 14, 2021
@dependabot dependabot bot mentioned this pull request Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zcating @pikax @antfu