Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): improve defineComponent type for option apis #406

Merged
merged 2 commits into from Jun 24, 2020
Merged

fix(type): improve defineComponent type for option apis #406

merged 2 commits into from Jun 24, 2020

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 23, 2020 •
edited

Resolve #338, Resolve #191

This should fix the most common use cases for type inference in defineComponent. Type inference of mixins and emit is not implemented in this PR.

@antfu antfu marked this pull request as draft June 23, 2020 18:19
@antfu antfu marked this pull request as ready for review June 23, 2020 18:29
@antfu antfu force-pushed the fix/type-define-component branch from 1cb270e to 2d8b0cc Compare June 23, 2020 19:06
@antfu
Copy link
Member Author

antfu commented Jun 23, 2020

@pikax Can you help review a bit? Sorry for being kinda huge.

I took a lot of code from vue-next as references. I also copied the defineComponent.test-d.ts from it, except for the mixins and emit parts. Tests are passing, so I think it should work fine. Just pinning you to be sure. Thank you.

This was hard and I have to say I learned Typescript better 😅

@antfu antfu mentioned this pull request Jun 23, 2020
Closed
@Aaron-Pool
Copy link

Thanks so much for getting a quick PR for this going, @antfu! It's super appreciated 🙇

@antfu antfu force-pushed the fix/type-define-component branch from 2d8b0cc to 3c3dc80 Compare June 24, 2020 09:56
@antfu antfu changed the base branch from rc to master June 24, 2020 09:56
@antfu
Copy link
Member Author

antfu commented Jun 24, 2020 •
edited

Force pushed to against master as this is not a breaking change. We can release the fix before 1.0.

pikax
pikax approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antfu antfu merged commit 1c64108 into vuejs:master Jun 24, 2020
@antfu antfu deleted the fix/type-define-component branch June 24, 2020 10:45
@sseeland sseeland mentioned this pull request Jun 25, 2020
Closed
@meschg meschg mentioned this pull request Oct 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript with composition-api: in methods, "this" is Vue, not current instance Access Data in render
3 participants
@antfu @Aaron-Pool @pikax