fix: not unwrapping markRaw objects

[pikax]

fix #384

[vmihailenco]

Thanks for fixing this.

Is there any way to undo unwrapping / get the target/underlying object? Something like undo(props.foo) which returns the target object which was not marked with markRaw.

[pikax]

Because of the vue2 limitations, when you change the ref it will change the underlying value

  it('test', ()=>{
    const a = {a:1 };
    const r = ref(a);

    r.value.a = 2

    expect(a.a).toBe(2)
  })

EDIT: Not sure if I understand your question

[vmihailenco]

Let me re-phrase it. Automatic unwrapping practically changes object like {foo: Ref<numer>} into {foo: number} using a Proxy / get&set. So instead of obj.foo.value I should/can write obj.foo. Is there any way to get original {foo: Ref<numer>} back from auto unwrapped {foo: number}?

PS I am okay with Vue 3 only solution - just want to understand what options I have.

[pikax]

Not currently possible.

How do you do that in vue3?

[vmihailenco]

How do you do that in vue3?

I don't know - I thought you have an idea. Thanks for the help and sorry for the offtopic.

[antfu]

That's weird to have "raw ref" 😅

Anyway, LGTM👍

[sapphi-red]

I found that when r is null or undefined, it causes TypeError: Cannot convert undefined or null to object.

[antfu]

Would it better to check falsy inside isRaw?

[pikax]

export function isRaw(obj: any): boolean {
  return !!obj && hasOwn(obj, RawIdentifierKey) && obj[RawIdentifierKey] === RawIdentifier;
}

Not sure if is will help, the idea is if is isRaw it shouldn't do anything to the object.

even if I add that condition on isRaw I still need to do unwrap, since we don't need to process falsy values