Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unwrapRefProxy native objects handling #376

Merged
merged 3 commits into from Jun 12, 2020
Merged

fix: unwrapRefProxy native objects handling #376

merged 3 commits into from Jun 12, 2020

Conversation

antfu
Copy link
Member

@antfu antfu commented Jun 12, 2020 •
edited

Resolve #375.

@antfu antfu requested a review from pikax June 12, 2020 07:19
pikax
pikax approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@pikax pikax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We shouldn't mix build with feature PR
package.json, rollup.config.js and yarn.lock should be other PR

antfu
antfu commented Jun 12, 2020
View reviewed changes
package.json Show resolved Hide resolved
@antfu
Copy link
Member Author

antfu commented Jun 12, 2020

I think this is kinda critical. I will merge it and make a release now.

@antfu antfu merged commit 8322fc7 into vuejs:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikax pikax pikax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Date will convert to plain object in template when no reactive
2 participants
@antfu @pikax