From aa7e27ea0618512e79daa3d920a21ce8ab459d1f Mon Sep 17 00:00:00 2001 From: Christian Kaisermann Date: Fri, 31 Jan 2020 17:59:11 -0300 Subject: [PATCH 1/3] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20add=20ramda=20and=20?= =?UTF-8?q?test-tools=20import=20messages?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/eslint-config-vtex/rules/imports.js | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-vtex/rules/imports.js b/packages/eslint-config-vtex/rules/imports.js index c0a1fb1..7e57ccb 100644 --- a/packages/eslint-config-vtex/rules/imports.js +++ b/packages/eslint-config-vtex/rules/imports.js @@ -8,7 +8,16 @@ module.exports = { 'no-restricted-imports': [ 'error', { - paths: ['lodash'], + paths: [ + { + name: 'lodash', + message: "Please use 'ramda' instead", + }, + { + name: '@testing-library/react', + message: "Please use '@vtex/test-tools/react' instead", + }, + ], patterns: ['lodash/*'], }, ], From c0de3865ffde1bb291c29c7c70db361c7099815d Mon Sep 17 00:00:00 2001 From: Christian Kaisermann Date: Fri, 31 Jan 2020 18:16:19 -0300 Subject: [PATCH 2/3] =?UTF-8?q?chore:=20=F0=9F=A4=96=20update=20changelog?= =?UTF-8?q?=20and=20add=20chan=20dep?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- package.json | 1 + packages/eslint-config-vtex/CHANGELOG.md | 2 ++ 2 files changed, 3 insertions(+) diff --git a/package.json b/package.json index 944dea3..d65b6ce 100644 --- a/package.json +++ b/package.json @@ -39,6 +39,7 @@ "postinstall": "lerna bootstrap && yarn build && lerna link" }, "devDependencies": { + "@geut/chan": "^2.1.1", "eslint": "^6.7.0", "husky": "^4.2.0", "lerna": "^3.18.4", diff --git a/packages/eslint-config-vtex/CHANGELOG.md b/packages/eslint-config-vtex/CHANGELOG.md index da23369..57b6fab 100644 --- a/packages/eslint-config-vtex/CHANGELOG.md +++ b/packages/eslint-config-vtex/CHANGELOG.md @@ -5,6 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html). ## [Unreleased] +### Added +- Add warning message for lodash and @testing-library imports. ## [12.0.3] - 2020-01-24 ### Fixed From fa3f663b30ce44719c376d8c689af1c3c1902d78 Mon Sep 17 00:00:00 2001 From: Christian Kaisermann Date: Fri, 31 Jan 2020 18:22:48 -0300 Subject: [PATCH 3/3] =?UTF-8?q?chore:=20=F0=9F=A4=96=20remove=20wrong=20ci?= =?UTF-8?q?=20task?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/ci.yml | 14 -------------- packages/eslint-config-vtex/rules/imports.js | 2 ++ 2 files changed, 2 insertions(+), 14 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ad72373..7e03d15 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,17 +9,3 @@ jobs: - uses: actions/checkout@v1 - uses: actions/setup-node@v1 - run: yarn && yarn lint - - Tests: - needs: [Lint] - runs-on: ubuntu-latest - steps: - - run: git config --global core.autocrlf false - - uses: actions/checkout@v1 - - uses: actions/setup-node@v1 - with: - node-version: 12 - - run: yarn - - run: cd node && yarn && yarn test - env: - CI: true diff --git a/packages/eslint-config-vtex/rules/imports.js b/packages/eslint-config-vtex/rules/imports.js index 7e57ccb..09087bd 100644 --- a/packages/eslint-config-vtex/rules/imports.js +++ b/packages/eslint-config-vtex/rules/imports.js @@ -18,6 +18,8 @@ module.exports = { message: "Please use '@vtex/test-tools/react' instead", }, ], + // Patterns don't support messages yet :( + // https://github.com/eslint/eslint/issues/11843 patterns: ['lodash/*'], }, ],