Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog.md to .prettierignore #57

Open
kaisermann opened this issue Jun 15, 2020 · 5 comments
Open

Add changelog.md to .prettierignore #57

kaisermann opened this issue Jun 15, 2020 · 5 comments

Comments

@kaisermann
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Our vtex setup --tooling command and templates should have a .prettierignore file which makes prettier ignore certain files. Since our CHANGELOG.md is made by hand, it can result in rebase conflicts if people have prettier re-formatting the file over and over again.

Describe the solution you'd like

  • Make vtex setup add a .prettierignore to a project.
  • Add changelog.md to .prettierignore.

Describe alternatives you've considered

Let people do whatever they please, which is not always the best idea.

Additional context

n/a

@kevinch
Copy link
Contributor

kevinch commented Jun 15, 2020

No chance to have a md format in this file case to just remove the black lines that cause the rebase issues? cc @lucasecdb

@stale
Copy link

stale bot commented Jun 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is a discussion thread, the most voted option will be final. Thank you for your contributions.

@stale stale bot added the stale This will not be worked on label Jun 22, 2020
@lucasecdb
Copy link
Contributor

not stale

@stale stale bot removed the stale This will not be worked on label Jun 22, 2020
@stale
Copy link

stale bot commented Jun 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is a discussion thread, the most voted option will be final. Thank you for your contributions.

@stale stale bot added the stale This will not be worked on label Jun 30, 2020
@lucasecdb
Copy link
Contributor

not staleee :sad-cat:

@stale stale bot removed the stale This will not be worked on label Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants