Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot display FAT structure on mtools-generated image #89

Open
ydirson opened this issue Jul 25, 2023 · 4 comments
Open

Cannot display FAT structure on mtools-generated image #89

ydirson opened this issue Jul 25, 2023 · 4 comments

Comments

@ydirson
Copy link

ydirson commented Jul 25, 2023

Hachoir (from Debian 3.1.0+dfsg-3) can parse the structure of a FAT image created by mkfs.msdos (showing first 0x200 bytes as Boot, then both FAT copies, and root directory), but on an image created by mtools (specifically mformat -i "test-mtools.img" ::.) it reports a MasterBootRecord partition table followed by only RawBytes, whereas those should be identified as a FAT.

Could this be the presence of a non-empty partition table causing 2 different dissectors to be used?

@vstinner
Copy link
Owner

Well, it seems like the parser is incomplete / has issues. You can dig into the code and propose a fix :-)

@ydirson
Copy link
Author

ydirson commented Jul 26, 2023

I'm unlikely to find the time for this, as going this far proved not necessary to get the cause of the glitch I was after. I'll leave this as an exercise for another potential contributor ;)

@vstinner
Copy link
Owner

Sadly, I'm no longer working on that project but @nneonneo is still hacking it sometimes :-)

@nneonneo
Copy link
Collaborator

Hello! Can you provide a sample file for me to look at? I do still hack on hachoir and still use it pretty often :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants