Prevent unhandled exception when running via schedule #69
Conversation
pull-request.py
Outdated
| @@ -395,7 +395,10 @@ def main(): | |||
| print("PULL_REQUEST_FROM_BRANCH is not set, checking branch in payload.") | |||
| with open(check_events_json(), "r") as fd: | |||
| from_branch = json.loads(fd.read()).get("ref") | |||
There was a problem hiding this comment.
Thank you for catching this! A question about your choice of fix - why not just do:
| from_branch = json.loads(fd.read()).get("ref") | |
| from_branch = json.loads(fd.read()).get("ref", "") |
And avoid the extra try / except and exception? The result of the above is an empty string, which won't trigger the error, and will cleanly exit in the next block telling the user to set the envar.
There was a problem hiding this comment.
Good point, that is cleaner. Updating now
|
Happy to help, thanks for the quick response and merge! There's no need to cut a new release just for this (unless that's your usual workflow). Either way I needed to update my Workflow to utilize |
|
I'm of the mindset to release often, so it's my preference to do a quick release. You should be good to go without it, but for provenance in this discussion, I'll link it here: https://github.com/vsoch/pull-request-action/releases/tag/1.0.16. Happy coding! <3 |
Resolves #68