Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): Add snakemake language icon #3420

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

ebete
Copy link
Contributor

@ebete ebete commented Jan 15, 2024

Add support for the Snakemake language.
Associated VSCode plugin: snakemake/snakemake-lang-vscode-plugin.

Fixes #3405

Changes proposed:

  • Add
  • Delete
  • Fix
  • Prepare

Comment on lines 4417 to 4418
extensionsGlob: ['smk', 'Snakefile'],
filenamesGlob: ['Snakefile'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be removed, given that this is covered already by the language id.

@robertohuertasm robertohuertasm added this to the Next milestone Jun 1, 2024
Copy link
Member

@robertohuertasm robertohuertasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the icon and fixed some issues. Thanks for your contribution.

@robertohuertasm robertohuertasm merged commit 4fd0291 into vscode-icons:master Jun 1, 2024
16 checks passed
@ebete ebete deleted the add-snakemake branch June 1, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icon Request]: Snakemake WfMS
2 participants