Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent ordering of dependency constraints in Puppetfile.lock #71

Open
benpillet opened this issue May 29, 2019 · 2 comments
Open

Comments

@benpillet
Copy link

Sometimes librarian-puppet install will update the Puppetfile.lock with the constraint in a different order than the original Puppetfile.lock.
e.g.
before:

...
puppet-archive (1.3.0)
    puppetlabs-stdlib (>= 4.6.0, < 5.0.0)
...

after:

...
puppet-archive (1.3.0)
    puppetlabs-stdlib (< 5.0.0, >= 4.6.0)
...

There's no logical difference in the dependency, but when the ordering changes, the diff changes and makes for git commit's that are long with many lines changing that obscure actual changes.

This may be an issue in librarianp, not librarian-puppet, but it I'm opening this to start the digging.

@benpillet benpillet changed the title Inconsistent dependency constraints in Puppetfile.lock Inconsistent ordering of dependency constraints in Puppetfile.lock May 29, 2019
@apatelKmd
Copy link

I am facing a similar issue and have changed my workflow to update the lock file manually. Below is the information on my setup:

$ ruby --version
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
$
$ bundle exec ruby --version
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]
$ 
$ bundle exec librarian-puppet version
librarian-puppet v3.0.0
$ 

@bvalente
Copy link

bvalente commented Sep 9, 2022

I know this is an old thread, but I think this issue might be related to this rubygems/rubygems#3889
Which means that you require a gems version above 3.2.0.rc.2
You can install the latest version with gem update --system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants