Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of bash-parser #46

Open
dthree opened this issue May 29, 2017 · 2 comments
Open

State of bash-parser #46

dthree opened this issue May 29, 2017 · 2 comments

Comments

@dthree
Copy link

dthree commented May 29, 2017

@parro-it just wanted to get exactly where this project is at.

While I know there are more bash features that need to be implemented, is it stable in its current state so that it could be built off?

// @milesj

@parro-it
Copy link
Collaborator

Hi @dthree, nice to see you on the road again 😸

Well, the AST structure should be stable for both the POSIX and the bash grammars.

The API will be changed soon to solve #43. The change will not be an easy one, but the change in public API signature will be small: parse will return a promise of the AST, and in the option argument, resolvePath callback would have to return a promise, while execCommand and execShellScript.

According to me, we can try the thing in a cash branch. I saw you are going to create a branch for v2 of cash: we can even use that...

There is a dependent package built by @substack on npm from some time now: https://www.npmjs.com/package/falafel-bash, but it's based on an older version of bash-parser.
I made a PR there to update the bash-parser version, but it's still unmerged by now...

@dthree
Copy link
Author

dthree commented Jun 1, 2017

Great!

API change doesn't seem to be too big a deal.

His package is pretty basic, so not sure that we should worry too much about getting it merged.

I'm actually looking at this for Vorpal 2.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants