Bugfix: Mio not blocking #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the mio-support feature is enabled, it doesn't block on .wait :-(. Reproducer for #16.
|
it works, with the following change: diff --git a/src/lib.rs b/src/lib.rs
index ff2dd18..2cb12cc 100644
--- a/src/lib.rs
+++ b/src/lib.rs
@@ -125,8 +125,8 @@ extern crate futures;
extern crate libc;
#[cfg(feature = "mio-support")]
extern crate mio;
-#[cfg(feature = "mio-support")]
-extern crate mio_uds;
+//#[cfg(feature = "mio-support")]
+//extern crate mio_uds;
extern crate signal_hook_registry;
#[cfg(feature = "tokio-support")]
extern crate tokio_reactor;Thank you for fixing this. PS: this passed too: |
The problem was, when the feature was enabled, the wakeup socket got switched to non-blocking mode (no matter if anything mio-related was actually used). So things that should have been blocking didn't and it was retrying the read from the pipe in a tight loop. Now we don't switch to non-blocking, but use the MSG_DONTWAIT flag when we need non-blocking read. Closes #16
|
Thanks, great to hear it works :-).
I wonder how came the tests were green without this change :-|. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@howaboutsynergy: This should fix the problem you reported (#16). Would you like to try it out yourself before I release it?