UB fixes #86
Merged
UB fixes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also improve performance of some tests in Miri
Turn into a pointer without re-borrowing.
Introduce a bit of future proof code to properly "close the brackets" around some operations (todays there are no-ops). Provide a bit of documentation for it, explaining the gymnastics there.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
- Coverage 80.85% 80.32% -0.53%
==========================================
Files 16 16
Lines 799 803 +4
==========================================
- Hits 646 645 -1
- Misses 153 158 +5
|
The idea is that the whole list (tail of the list) is synchronized by the access of the head. Nevertheless, we fill in the next pointer before that and having a reference is formally considered a read of the destination. Even though we _use_ the reference only after the synchronization point, we have it before and MIRI considers it a data race. Using a pointer is fine, as dereferencing is manual and considered read only at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.