Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cespare should update to v2.1.2 #1756

Closed
zishen opened this issue Sep 22, 2021 · 5 comments · Fixed by #1996
Closed

cespare should update to v2.1.2 #1756

zishen opened this issue Sep 22, 2021 · 5 comments · Fixed by #1996
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@zishen
Copy link
Contributor

zishen commented Sep 22, 2021

What happened:

When imported and build with -buildmode=plugin or anything use dynamic link, go will throw

when dynamic linking, R15 is clobbered by a global variable access and is used here:
cespare:54

And k8s also accepted k8s:105133,k8s:105142

Anything else we need to know?:
can update go mod's replace to repair:
github.com/cespare/xxhash/v2 => github.com/cespare/xxhash/v2 v2.1.2

Environment:

  • Volcano Version: v1.4.0
  • Kubernetes version (use kubectl version):1.22,1.22.1
  • Go: 1.17,1.17.1
@zishen zishen added the kind/bug Categorizes issue or PR as related to a bug. label Sep 22, 2021
@stale
Copy link

stale bot commented Dec 21, 2021

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2021
@zishen
Copy link
Contributor Author

zishen commented Jan 9, 2022

Hello 👋 Looks like there was no activity on this issue for last 90 days. Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗 If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@Lion-Wei
v1.5.0 still has these issue.

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 9, 2022
@zishen
Copy link
Contributor Author

zishen commented Jan 14, 2022

@Thor-wl

@hwdef
Copy link
Member

hwdef commented Jan 14, 2022

This is useful, do you want to do this?

@zishen
Copy link
Contributor Author

zishen commented Jan 14, 2022

This is useful, do you want to do this?

Ok, let me have a try.

zishen added a commit to zishen/volcano that referenced this issue Feb 16, 2022
in v1.5.0

See cespare/xxhash@v2.1.2...main for more details.

Format with Go 1.17 gofmt to use //go:build constraints
/kind bug

Signed-off-by: zishen softwarebtg@163.com
zishen added a commit to zishen/volcano that referenced this issue Feb 16, 2022
in v1.5.0

See cespare/xxhash@v2.1.2...main for more details.

Format with Go 1.17 gofmt to use //go:build constraints
/kind bug

Signed-off-by: zishen softwarebtg@163.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants