[feature request] MySQL Optimizer Hints

[mickeyreiss]

MySQL has support for Optimizer Hints, which implemented with comments that appear between SELECT and the column list.

For example:

SELECT /*+ MAX_EXECUTION_TIME(1000) */ * FROM users;

I would like to be able to insert optimizer hints with a query mod, maybe something like this:

models.Users(
	qm.OptimizerHint("MAX_EXECUTION_TIME(%d)", 1000),
).All(ctx)

[mickeyreiss]

Here is some WIP for adding this feature: 14739a8. It looks like it would be relatively simple to add—similar to #872.

[stephenafamo]

Can you create a PR for this? It would be much easier to review.

[mickeyreiss]

Can you create a PR for this? It would be much easier to review.

@stephenafamo my solution isn't fully baked yet. For example, I haven't considered databases other than MySQL. I wanted to get feedback on the feature and approach before opening a pull request. If you see any issues as is, feel free to leave a comment on the commit.

[stephenafamo]

I haven't considered databases other than MySQL

Yes, this is an issue because SQLboiler uses the same query builder for all dialects.

Personally, I think it is fine. Because it is similar to qm.Returning which is not supported in MySQL but we have mods for it.