Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tests: Update to the new Galata setup #940

Closed
jtpio opened this issue Sep 2, 2021 · 1 comment · Fixed by #946
Closed

UI Tests: Update to the new Galata setup #940

jtpio opened this issue Sep 2, 2021 · 1 comment · Fixed by #946
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Sep 2, 2021

Problem

The new galata setup now lives in the core JupyterLab repo: https://github.com/jupyterlab/jupyterlab/tree/master/galata

We should update to it, as it comes with many improvements.

Proposed Solution

Update the ui-tests setup here: https://github.com/voila-dashboards/voila/tree/master/ui-tests

Following the instructions here: https://github.com/jupyterlab/jupyterlab/tree/master/galata

Additional context

Galata was moved to the core lab repo in jupyterlab/jupyterlab#10796

@jtpio jtpio added enhancement New feature or request maintenance and removed enhancement New feature or request labels Sep 2, 2021
@jtpio jtpio added this to the 0.2.x milestone Sep 2, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 2, 2021

Looks like the current UI Tests check is still a bit flaky. So doing the update might help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant