Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file_allowlist limited to root directory only? #1437

Open
tilusnet opened this issue Jan 14, 2024 · 1 comment
Open

file_allowlist limited to root directory only? #1437

tilusnet opened this issue Jan 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@tilusnet
Copy link

Description

I am using a file allowlist to serve static pages defined as follows:

{
    "VoilaConfiguration": {
        "file_allowlist": [
            ".*\\.(png|jpg|gif|svg|mp4|avi|ogg|html|js)"
        ]
    }
}

Prior to v0.5.0 this wildcard definition allowed access to any matching file, including relative paths under the root.

However this seems broken now: if I place a file foo/bar.html, it is not found (404 error).
If I place it under root as bar.html, it is found and rendered as expected.

Did some logic change with #1367 ?

Context

  • voila version 0.5.5
  • Operating System and version: Ubuntu Linux 20.04 LTS
  • Browser and version: Chrome v120
@tilusnet tilusnet added the bug Something isn't working label Jan 14, 2024
@jgunstone
Copy link

linking this #1397 (also about file_allowlist ) in case related...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants