Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] add support for security compliance in content library item API #2980

Closed
ericvmw opened this issue Oct 31, 2022 · 5 comments · Fixed by #2982
Closed

[BUG] add support for security compliance in content library item API #2980

ericvmw opened this issue Oct 31, 2022 · 5 comments · Fixed by #2982

Comments

@ericvmw
Copy link
Contributor

ericvmw commented Oct 31, 2022

Describe the bug
Security policy support in content library (vSphere 7.0u3) introduced new API fields in the library and library item APIs, some of the APIs are not supported in govmomi content library client.

To Reproduce
Call the following API via content library client doesn't show security compliance and certificate info:

Expected behavior
security_compliance and certificate_verification_info should show in item info if set:
https://developer.vmware.com/apis/vsphere-automation/latest/content/api/content/library/item/library_item_id/get/

trusted certificate API should be added to the API client:
https://developer.vmware.com/apis/vsphere-automation/latest/content/content/trusted_certificates/

Affected version
content library running on vSphere 7.0u3 and later.

Screenshots/Debug Output
compliance API field is not in the library item info output in govc CLI:

$ govc library.info secure-lib/trivial
Name: trivial
ID: 7d789e81-9064-478e-8236-7c25ac916d4a
Path: /secure-lib/trivial
Description:
Type: ovf
Size: 486B
Created: Mon Oct 31 18:22:33 2022
Modified: Mon Oct 31 18:22:39 2022
Version: 1

Additional context

@github-actions
Copy link
Contributor

Howdy 🖐   ericvmw ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

@dougm
Copy link
Member

dougm commented Oct 31, 2022

@ericvmw sounds like this is what @brakthehack added in #2909 , which was after the current 0.29 release tag.

@ericvmw ericvmw changed the title [BUG] add support for security policy in content library and item APIs [BUG] add support for security compliance in content library item API Nov 1, 2022
@ericvmw
Copy link
Contributor Author

ericvmw commented Nov 1, 2022

@ericvmw sounds like this is what @brakthehack added in #2909 , which was after the current 0.29 release tag.

Thanks @dougm for the info, I didn't check the latest source code. It looks the latest still misses some APIs on content library security policy: the security_compliance & certificate_verification_info in library item and trust certificate API. I just updated the description of this issue, please let me know if it makes sense.

@dougm
Copy link
Member

dougm commented Nov 2, 2022

Thanks @dougm for the info, I didn't check the latest source code. It looks the latest still misses some APIs on content library security policy: the security_compliance & certificate_verification_info in library item and trust certificate API. I just updated the description of this issue, please let me know if it makes sense.

Make sense, thanks @ericvmw . Let me know if I can help you with adding these.

@ericvmw
Copy link
Contributor Author

ericvmw commented Nov 3, 2022

Yes please add them if you can, Thanks @dougm !

dougm added a commit to dougm/govmomi that referenced this issue Nov 4, 2022
govc: add libray.trust{ls,info,create,rm} commands

Fixes vmware#2980
dougm added a commit to dougm/govmomi that referenced this issue Nov 8, 2022
govc: add libray.trust{ls,info,create,rm} commands

Fixes vmware#2980
priyanka19-98 pushed a commit to priyanka19-98/govmomi that referenced this issue Jan 17, 2024
govc: add libray.trust{ls,info,create,rm} commands

Fixes vmware#2980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants