SRIOV device names

[sunnycarter]

Is your feature request related to a problem? Please describe.
SR-IOV, Single Root I/O Virtualization, allows a single NIC (termed the Physical Function - PF) to be shared between a bounded number of VMs, providing a Virtual Function (VF) network interface to each VM. It is used for high-performance throughput on the network interface.

In VMWare, Ethernet devices of UnitNumber 7-19 are non-SRIOV. Ethernet devices of UnitNumber 45-36 descending are SRIOV.
Current code uses the UnitNumber to determine the device name, but it only takes into account non-SRIOV devices.
It is necessary to have a different stable name for SRIOV devices that takes this into account, otherwise non-SRIOV devices and SRIOV devices can be confused.

Without this, I cannot support SRIOV in the terraform vsphere provider: hashicorp/terraform-provider-vsphere#1417 as it cannot differentiate between devices using the name.
A clear and concise description of what the problem is. Ex. I cannot do X because [...]

Describe the solution you'd like
I'd like the Name function in virtual_device_list.go for DeviceTypeEthernet to return:
[devicetype]-0 for unit Number 7
[devicetype]-1 for unit Number 8
etc
[devicetype]-sriov-0 for unit number 45
[devicetype]-sriov-1 for unit number 44
etc.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here. used to include the govmomi copied into that repo. Now instead it references this repo, hence I am moving the relevant part of that Pull Request here.

[github-actions]

Howdy 🖐   sunnycarter ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.