Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcsim: Fix disk capacity fields in ReconfigVM_Task #2890

Merged
merged 1 commit into from Jul 5, 2022

Conversation

Syuparn
Copy link
Contributor

@Syuparn Syuparn commented Jun 27, 2022

Description

Fix ReconfigVM_Task in vcsim so that both of CapacityInBytes and CapacityInKB in VirtualDisk are updated.

Closes: #2889

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • add unit tests

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#2889
Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Syuparn

@dougm dougm merged commit 109a93b into vmware:master Jul 5, 2022
@Syuparn Syuparn deleted the issue-2889 branch July 6, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] vcsim: ReconfigVM_Task incompletely updates disk's capacity
2 participants