Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Link to CONTRIBUTION guidelines in Pull Request template is broken #2884

Closed
atc0005 opened this issue Jun 21, 2022 · 2 comments · Fixed by #2888
Closed

[BUG] Link to CONTRIBUTION guidelines in Pull Request template is broken #2884

atc0005 opened this issue Jun 21, 2022 · 2 comments · Fixed by #2888
Assignees

Comments

@atc0005
Copy link
Contributor

atc0005 commented Jun 21, 2022

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Open a new pull request
  2. Scroll to the Checklist section
  3. Opt to Preview the GH issue as it currently is
  4. Attempt to follow the link to the CONTRIBUTION guidelines

Expected behavior

Working link

Affected version

https://github.com/vmware/govmomi/blob/06eb50d897338eea7451a2c0ee2ff560f20159dd/.github/PULL_REQUEST_TEMPLATE.md

Screenshots/Debug Output

N/A

Additional context

N/A

@embano1
Copy link
Contributor

embano1 commented Jun 22, 2022

Just tried to follow your steps, but can't find a "checklist" section nor the CONTRIB link in the issue template?

When I create an issue of type "bug" I see a Contributing link in the "Helpful resources" section on the right. This link works too.

Did you mean the PR template by chance?

@atc0005 atc0005 changed the title [BUG] Link to CONTRIBUTION guidelines in bug report template is broken [BUG] Link to CONTRIBUTION guidelines in Pull Request template is broken Jun 22, 2022
@atc0005
Copy link
Contributor Author

atc0005 commented Jun 22, 2022

@embano1: Did you mean the PR template by chance?

You're right, sorry about that. I think I filled this out while preparing #2885 and wasn't paying as much attention as I should have. I've updated the OP to reflect the correction.

Note: When viewing the PR template directly the relative link works, but once the PR template is used to produce a PR the link no longer works.

@embano1 embano1 self-assigned this Jun 27, 2022
embano1 pushed a commit to embano1/govmomi that referenced this issue Jun 27, 2022
Closes: vmware#2884
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants