Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate negative device key in AssignController #2882

Merged
merged 1 commit into from Jun 22, 2022

Conversation

Syuparn
Copy link
Contributor

@Syuparn Syuparn commented Jun 21, 2022

Description

Fix VirtualDeviceList#AssignController to always generate negative device keys so that they will not collide with existing keys.

Closes: #2881

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • Add unit tests

Checklist:

  • My code follows the CONTRIBUTION guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Closes: vmware#2881
Signed-off-by: syuparn <s.hello.spagetti@gmail.com>
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @Syuparn !

@dougm dougm merged commit 06eb50d into vmware:master Jun 22, 2022
@Syuparn Syuparn deleted the issue-2881 branch June 22, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VirtualDeviceList.AssignController may generate positive device key
2 participants