Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for missing Tanzu namespace management CRUD functionality #2860

Closed
adamfowleruk opened this issue May 29, 2022 · 1 comment
Closed

Comments

@adamfowleruk
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the existing namespace Enable call is missing vSphere networking options as well as the WorkloadNTPServers option. This means the same set up you can create manually is not possible via govmomi API calls today.

In addition there are some other API calls required for a Terraform provider I'm creating that are missing in govmomi:-

  • GET https://{api_host}/api/vcenter/namespace-management/clusters/{cluster} - required by resource_cluster readCluster
    • ListClusters is insufficient due to how terraform determines whether a resource needs updating/deleting/creating
    • Note that Create in terraform is followed by a read.
  • PUT https://{api_host}/api/vcenter/namespace-management/clusters/{cluster} - required by resource_cluster updateCluster
    • Used to replace a whole config without a disable/enable loop

Other ancillary calls are likely missing too (E.g. PATCH to add a workload network), but the above are the big ticket items preventing Infrastructure as Code and GitOps approaches being used.

Describe the solution you'd like
These API calls added to govmomi/vapi/namespace.go so I can complete my provider.

Describe alternatives you've considered
Rolling my own client library, but it seemed excessive, and wouldn't help the broader community.

Additional context
I'm happy to implement the feature myself (I work in MAPBU in VMware as a Platform Architect), so this is really just for tracking, unless someone wants to add these pieces themselves in the interim, if its quicker?

adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue May 30, 2022
Added additional fields not prevent in 7.0.0, allowing use up to 7.0u3
Signed-off-by: Adam Fowler <adam@adamfowler.org>
@embano1
Copy link
Contributor

embano1 commented May 30, 2022

I'm happy to implement the feature myself

Go for it, much appreciated!

adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue May 31, 2022
Part of vmware#2860. 
Signed-off-by: Adam Fowler <adam@adamfowler.org>
adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue Jul 15, 2022
Signed-off-by: Adam Fowler <adam@adamfowler.org>
adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue Jul 15, 2022
…o issue-2860

Signed-off-by: Adam Fowler <adam@adamfowler.org>
adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue Jul 15, 2022
…e 7.0u2 and above

Closes vmware#2860.
Merge remote-tracking branch 'vmware/master' into issue-2860
Signed-off-by: Adam Fowler <adam@adamfowler.org>
adamfowleruk added a commit to adamfowleruk/govmomi that referenced this issue Jul 20, 2022
Closes: vmware#2860
Signed-off-by: Adam Fowler <adam@adamfowler.org>
@dougm dougm closed this as completed in 642156d Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants