New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
govc: Use unique searchFlagKey when calling NewSearchFlag #2850
Conversation
@makelarisjr, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @makelarisjr ! Please go ahead and squash the commits and I will merge
PR vmware#2850 fix a search flag issue with the vm.clone command, but caused an issue with the vm.migrate command. Rather than embed the SearchFlag directly, vm.migrate needs to embed the VirtualMachineFlag Issue vmware#2849
@makelarisjr, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement. |
@makelarisjr, VMware has rejected your signed contributor license agreement. The change has already been merged, but it will be backed out by the project maintainers if the agreement is not resigned in a timely manner. Click here to resign the agreement. |
@makelarisjr, VMware has approved your signed contributor license agreement. |
Description
When cloning a VM if you specify the
-host.dns
flag it throws the errorexpected VirtualMachine entity, got HostSystem
, this is because the SearchFlag instance is saved in the context with a staticsearchFlagKey
Closes: #2849
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
I successfully cloned a VM by using this command:
./govc vm.clone -vm "TestDHCP" -host.dns "esxi-eu-dev-01.example.com" testvm
Checklist:
this project