Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ENTRYPOINT and CMD combination in vcsim Dockerfile #2841

Closed
embano1 opened this issue May 11, 2022 · 0 comments · Fixed by #2842
Closed

Use ENTRYPOINT and CMD combination in vcsim Dockerfile #2841

embano1 opened this issue May 11, 2022 · 0 comments · Fixed by #2842
Assignees
@embano1

Comments

@embano1
Copy link
Contributor

embano1 commented May 11, 2022

We should set /vcsim as ENTRYPOINT but allow customization with CMD based args instead of only using CMD (it's a scratch container so there is only one ENTRYPOINT ever).

govmomi/Dockerfile.vcsim

Lines 45 to 46 in 72c2000

# Set entrypoint to application with container defaults
CMD ["/vcsim", "-l", "0.0.0.0:8989"]

Ref: vmware-tanzu/sources-for-knative#442 (comment)
@embano1 embano1 self-assigned this May 11, 2022
@embano1 embano1 mentioned this issue May 11, 2022
Merged
13 tasks
@embano1 embano1 changed the title Use ENTRYPOINT and CMD combination in Dockerfiles Use ENTRYPOINT and CMD combination in vcsim Dockerfile May 11, 2022
embano1 pushed a commit to embano1/govmomi that referenced this issue May 11, 2022
vcsim: Update Dockerfile
8928a48 
The `vcsim` Dockerfile now uses `ENTRYPOINT` for the `vcsim` binary and
`CMD` for default listener address `0.0.0.0:8989`. A user can now easily
overwrite the default behavior without having to specify `/vcsim`
explicitly since it is the defined `ENTRYPOINT`.

Closes: vmware#2841
Signed-off-by: Michael Gasch <mgasch@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@embano1 embano1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vcsim: Update Dockerfile embano1/govmomi
1 participant
@embano1