govc: Handle powered-on VMs in vm.destroy

[embano1]

Description

govc vm.destroy might throw error in vCenter UI/task log if the vm to be destroyed is already powered off. This non-breaking change checks the power state of a VM, and if it is powered on a power off attempt will be performed.

Closes: #2529
Signed-off-by: Michael Gasch mgasch@vmware.com

Type of change

Please mark options that are relevant:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to
  not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

• Added govc bats test

Test Configuration:

• Toolchain:
• SDK:
• (add more if needed)

Checklist:

• My code follows the CONTRIBUTION guidelines of
  this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

[dougm]

Thanks @embano1 . We could check the power state of the VM(s) and only power off those that are poweredOn.
If we want the flag option, can we name it -off (same as vm.power's flag) and default to true?

[embano1]

Thx Doug, sounds like a reasonable change to me.

[Petrapana]

Hello,
Will it be possible to merge this change?

[embano1]

@Petrapana just back from PTO and hope to finish this by EOW

[embano1]

@dougm made changes as per your comment, no additional flag needed.

[dougm]

lgtm, thanks @embano1