Add query escape to query params in GetURI #2903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Ang <christian.ang@broadcom.com>
christianang
force-pushed
the
query-escape-params
branch
from
a000cb1
to
132a966
Compare
Rohan-sss1
approved these changes
Mar 26, 2024
|
Hi @Rohan-sss1 could you help merge this PR. Thank you |
|
Hi @parimanur @apalsule @akshayhavile could you help merge this PR? |
|
The changes for this PR were included in #2933. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps query params in
GetURIwithurl.QueryEscapeto ensure query is well formed e.g if I provideVM Networkit will be converted intoVM+Network. This seems to be expected in the Avi 30.1.1 API.Fixes #2902