-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove snapshotVolumes flag necessity for volume policy snapshot action #7786
Remove snapshotVolumes flag necessity for volume policy snapshot action #7786
Conversation
Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> fix via make update Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com> add changelog Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>
55cd12b
to
9f10b0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7786 +/- ##
==========================================
- Coverage 58.66% 58.65% -0.01%
==========================================
Files 344 344
Lines 28731 28730 -1
==========================================
- Hits 16854 16853 -1
Misses 10448 10448
Partials 1429 1429 ☔ View full report in Codecov by Sentry. |
@shubham-pampattiwar
velero/pkg/backup/item_backupper.go Line 410 in 7563a45
velero/pkg/controller/backup_controller.go Line 508 in 7563a45
4. Looks like this is a gap during the design discussion, as I see the design is aligned with the current code, so we also need to change the design as well. If you need a live discussion or need any help from us, just let us know. Thanks. |
/cc @anshulahuja98 @vmware-tanzu/velero-maintainers |
@shubham-pampattiwar |
closing this PR in favor of #7794 |
Thank you for contributing to Velero!
Please add a summary of your change
Remove snapshotVolumes flag necessity for volume policy snapshot action
Does your change fix a particular issue?
Fixes #7782
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.