Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero command without subcommand returns error #2946

Closed
nrb opened this issue Sep 17, 2020 · 2 comments
Closed

velero command without subcommand returns error #2946

nrb opened this issue Sep 17, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@nrb
Copy link
Contributor

nrb commented Sep 17, 2020

What steps did you take and what happened:
Running velero without a subcommand now returns an error.

What did you expect to happen:
velero without a subcommand should return a help message, but no error.

The output of the following commands will help us better understand what's going on:

Anything else you would like to add:
This appears to be from Cobra v0.0.6, specifically https://github.com/spf13/cobra/blob/v0.0.6/command.go#L957. We need to check for this error and not bubble it up.

Environment:

  • Velero version (use velero version): v1.5.1

Vote on this issue!

This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.

  • 👍 for "I would like to see this bug fixed as soon as possible"
  • 👎 for "There are more important bugs to focus on right now"
@nrb nrb added the Bug label Sep 17, 2020
@nrb nrb added this to the v1.5.2 milestone Sep 17, 2020
@zubron
Copy link
Contributor

zubron commented Sep 17, 2020

This was reported as an issue in spf13/cobra#1056 as is fixed in the 0.0.7 release so hopefully it's enough to just upgrade the version we're using.

@nrb nrb self-assigned this Sep 17, 2020
@nrb
Copy link
Contributor Author

nrb commented Sep 18, 2020

Forgot to add a fixes string in the PR. This was closed by #2947.

@nrb nrb closed this as completed Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants