Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

MachineDeployment customizations with nested arrays, fail , due to ProcessYamlObjectArrayInterfaceType. #4526

Open
jayunit100 opened this issue Mar 28, 2023 · 0 comments · May be fixed by #4527
Open

MachineDeployment customizations with nested arrays, fail , due to ProcessYamlObjectArrayInterfaceType. #4526

jayunit100 opened this issue Mar 28, 2023 · 0 comments · May be fixed by #4527
Labels
area/lcm Related to Cluster Lifecycle management kind/bug PR/Issue related to a bug

Comments

@jayunit100
Copy link
Contributor

In the MachineDeployment customizations, we parse incoming cluster objects, which look something like this:

    workers:
      machineDeployments:
      - class: tkg-worker
        metadata:
          annotations:
            run.tanzu.vmware.com/resolve-os-image: image-type=ova,os-name=ubuntu
        name: md-0
        replicas: 1
      - class: tkg-worker
        metadata:
          annotations:
            run.tanzu.vmware.com/resolve-os-image: image-type=ova,os-name=ubuntu
        name: md-1-gpu
        replicas: 1
        variables:
          overrides:
          - name: worker
            value:
              count: 1
              machine:
                customVMXKeys:
                  pciPassthru.64bitMMIOSizeGB: "16"
                  pciPassthru.RelaxACSforP2P: "true"
                  pciPassthru.allowP2P: "true"
                  pciPassthru.use64bitMMIO: "true"
                diskGiB: 300
                memoryMiB: 16384
                numCPUs: 4
                hardwareVersion: vmx-17

The above code works fine, but if we add another map, which has an array in it `map[string]interface .....

                devices:
                - deviceId: 1234 <-- this fails
                  vendorId: 6789

It fails. Thats because it appears we dont parse nested lists. In the linked PR ive attached a PR that reproduces this, so it can be easy to fix now.
@jayunit100 jayunit100 added kind/bug PR/Issue related to a bug needs-triage Indicates an issue or PR needs to be triaged labels Mar 28, 2023
@jayunit100 jayunit100 linked a pull request Mar 28, 2023 that will close this issue
Open
@codegold79 codegold79 added area/lcm Related to Cluster Lifecycle management and removed needs-triage Indicates an issue or PR needs to be triaged labels Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/lcm Related to Cluster Lifecycle management kind/bug PR/Issue related to a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pci passthrough unit tests reproducer of nested arrays issue vmware-tanzu/tanzu-framework
2 participants
@jayunit100 @codegold79