Adapt to controller-runtime client changes #327
Conversation
The controller-runtime client has new methods for interacting with sub resources. The fake client is updated to implement the new interface. Interacting with any sub resource, other than status, will trigger the reactor chain with no other pre-defined behavior. Custom reactors must be installed in order to observe/handle the request. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportBase: 61.55% // Head: 60.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
==========================================
- Coverage 61.55% 60.51% -1.05%
==========================================
Files 17 17
Lines 2154 2193 +39
==========================================
+ Hits 1326 1327 +1
- Misses 751 789 +38
Partials 77 77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
LGTM! Thank you
[thought]: The ReconcilerTestCase has ExpectStatusUpdates and ExpectStatusPatches. Do you reckon that it should eventually move towards an API akin to ExpectSubResource[Updates, Patches]?
https://github.com/vmware-labs/reconciler-runtime/blob/main/testing/reconciler.go#L67-L70
I went down that rabbit hole initially. It's a breaking change that creates a worse experience for almost zero benefit. Using an ExpectSubResource* field wouldn't be able to accept client.Object, but would need to wrap that in some new struct that is aware of which sub resource is being called. Assertions are tricky because the sub resource can have different semantics. For example, the status sub resource, we ignore any field not under The new sub resource client doesn't feel fully baked. We need to support the interface in order to compile, but I'm not ready to build much that's more meaningful on top. We'll see how it goes. |
The controller-runtime client has new methods for interacting with sub resources. The fake client is updated to implement the new interface. Interacting with any sub resource, other than status, will trigger the reactor chain with no other pre-defined behavior. Custom reactors must be installed in order to observe/handle the request.
Resolves #325